nunit-dev team mailing list archive

["Charlie Poole" <charlie@xxxxxxxxx>]

Hi All, 

I just updated the status of my trial merge to 'Approved'
I assume I was able to do that because I'm a member of 
nunit-core, but I'd like to verify that.

Who gets the little yellow links to change the status and
commit message? Who doesn't?

Charlie 

> -----Original Message-----
> From: nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxxx 
> [mailto:nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxx
> t] On Behalf Of Charlie Poole
> Sent: Friday, August 14, 2009 6:00 PM
> To: nunit-dev@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Nunit-dev] Review of Changes
> 
> Hi All,
> 
> I just went on line and voted in favor of my own change. :-)
> 
> I like the online review screen, which gives diffs in a nice 
> format. This seems to make it worthwhile to go through the 
> effort of getting them into Launchpad.
> 
> Just got an email notification with my friendly comment, so 
> it looks like the two interfaces (email and web) interoperate.
> 
> It's not clear to me if others who are not on the nunit-core 
> team are allowed to review it. Somebody please go here and try it out:
> 
> https://code.launchpad.net/~charlie.poole/nunit-2.5/merge/+merge/10197
> 
> One thing I'm not clear on: How do we decide that the voting 
> is over and we're applying the change? Or not? Of course the 
> policy is up to us, but does Launchpad need to be told? Does 
> Launchpad do anything or does a committer have to take action?
> (I'm guessing the latter, but hoping Paul will tell us for sure.)
> 
> Charlie
> 
> > -----Original Message-----
> > From: nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxxx
> > [mailto:nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxx
> > t] On Behalf Of Charlie Poole
> > Sent: Friday, August 14, 2009 5:48 PM
> > To: nunit-dev@xxxxxxxxxxxxxxxxxxx
> > Subject: [Nunit-dev] Review of Changes
> > 
> > Hi All,
> > 
> > I experimented with sending a merge directive to the 
> launchpad merge 
> > address: merge@xxxxxxxxxxxxxxxxxx as Paul suggested.
> > 
> > The Core Developers team got the review request by default, 
> but I can 
> > see how to change it so all of you get it. I have attached what was 
> > sent to us so everyone can see what it looks like.
> > 
> > I gather that the reviews can be made by email or on the 
> web site. I 
> > assume that we need to use email if we want to actually discuss the 
> > fix. Paul, can you confirm?
> > 
> > I found a few drawbacks to this approach.
> > 
> > 1. I had to try a number of times, making several changes to 
> > locations.conf and bazaar.conf before I got it right. It's 
> really easy 
> > once you have it set up correctly, but I don't consider myself a 
> > slouch at such things and if it took me a while it may totally stop 
> > some potential contributors.
> > 
> > 2. You must sign your email with your GPG key. This is not 
> something 
> > most windows developers are set up to do so there is a bit of a 
> > learning curve. Using Outlook, the only way I could figure 
> out to get 
> > my email signed was via the clipboard.
> > I believe that voting via email also requires a GPG key.
> > 
> > One thing we could try to do is give step by step 
> instructions about 
> > how to configure and how to use GPG. Some of this is already 
> > available, but it's not always clear how a Windows user 
> does it - and 
> > most of our potential developers are in the world of windows.
> > 
> > The alternatives - I guess - to this approach are...
> > 
> > 1. Just send a simple patch to the dev list and let somebody else 
> > figure it out. This may be the best for the complete newbie.
> > 
> > 2. Push your branch to Launchpad and then propose it for 
> merging via 
> > the web site. This requires that you have an SSH client and key set 
> > up, which is yet another step, but people may already have 
> this from 
> > using Sourceforge or some other site.
> > 
> > I'm looking for some ideas on this. How should we start out?
> > What direction should we try to take it?
> > 
> > Charlie
> > 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~nunit-dev
> Post to     : nunit-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~nunit-dev
> More help   : https://help.launchpad.net/ListHelp
>