nuvola-player-devel team mailing list archive

[Jiří Janoušek <janousek.jiri@xxxxxxxxx>]

Review: Needs Fixing

=== modified file 'data/nuvolaplayer/services/googleplay/integration.js'
35	+ navigateBack.addEventListener('click', function() {window.history.back();});
45	+ navigateFwd.addEventListener('click', function() {window.history.forward();});

Use Nuvola.triggerAction("back") and Nuvola.triggerAction("forward").

=== modified file 'data/nuvolaplayer/services/googleplay/settings.js'
98	+ Nuvola.saveConfig();
99	+ form.showReloadNotice();

Could it be possible to apply this setting live without form.showReloadNotice()? Nuvola.saveConfig() emits signal cmd="config-changed" in Integration.prototype.messageHandler. You can check for it to add/remove buttons instantly.

=== modified file 'data/nuvolaplayer/services/googleplay/integration.js'
48	+ var navigationStack = [];

Could you rework your code to use the new actions API (see bug LP:1265290) and fall back to your navigationStack if(Nuvola.Action === undefined) for Nuvola Player <= 2.3?

- var back = new Nuvola.Action("back");
- var forward = new Nuvola.Action("forward");
- in Integration.prototype.messageHandler(cmd, param1, param2) check for signal ("action-changed", back.name/forward.name, "sensitive")
-- 
https://code.launchpad.net/~mpdeimos/nuvola-player/bug-1212167/+merge/200249
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.