nuvola-player-devel team mailing list archive

[mpdeimos <mpdeimos@xxxxxxxxx>]

Review: Resubmit

Incorporated your ideas.

Some comments:

* The feature is disabled on pre 2.4 versions. I the navigation stack is a hack and I do not like to keep it even as compatibility code. Especially if the buttons are added to other services.

* I'm directly assigning this.naviagteBack.disabled again. The reason for not using the makeElement shorthand is, that this uses dom attributes and this means it will always be disabled (according to html spec, <button disable="anything"/> will disable the button).

* I'm exposing Nuvola.ACTION_CHANGED instead of using "action-changed"

* The JS API version should be bumped to 2.3 (have not done this)

* I think the other Google Play Service options can also be dynamically activated. I may add a ticket for this later.
-- 
https://code.launchpad.net/~mpdeimos/nuvola-player/bug-1212167/+merge/200249
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.