opencompute-developers team mailing list archive

[Jeff Marcom <jeff.marcom@xxxxxxxxxxxxx>]

Jeff Marcom has proposed merging lp:~jeffmarcom/opencompute/cleanup_of_ipmi_oob_jobs into lp:opencompute/checkbox.

Requested reviews:
  Open Compute Developers (opencompute-developers)

For more details, see:
https://code.launchpad.net/~jeffmarcom/opencompute/cleanup_of_ipmi_oob_jobs/+merge/177206

This is a simple cleanup of the current out of band ipmi tests.

In this merge request I've moved the remote ipmi jobs to their own out_of_band job file for clarity.
This also serves as a "how to" for making and including new tests in a whitelist.

Output from successful run against OCPv2 hardware:

Out of Band IPMI tests

   ipmi/out_of_band/admin/chassis_self_test [pass]
   ipmi/out_of_band/admin/chassis_status [pass]
   ipmi/out_of_band/admin/detailed_sensor_readings [pass]
   ipmi/out_of_band/admin/power_cycle [pass]
   ipmi/out_of_band/admin/power_off [pass]
   ipmi/out_of_band/admin/power_on [pass]
   ipmi/out_of_band/admin/power_policy_always_off [pass]
   ipmi/out_of_band/admin/power_policy_always_on [pass]
   ipmi/out_of_band/admin/power_policy_previous [pass]
   ipmi/out_of_band/admin/power_reset [pass]

-- 
https://code.launchpad.net/~jeffmarcom/opencompute/cleanup_of_ipmi_oob_jobs/+merge/177206
Your team Open Compute Developers is requested to review the proposed merge of lp:~jeffmarcom/opencompute/cleanup_of_ipmi_oob_jobs into lp:opencompute/checkbox.

=== modified file 'data/whitelists/opencompute-ready-remote.whitelist'
--- data/whitelists/opencompute-ready-remote.whitelist	2013-07-08 15:22:08 +0000
+++ data/whitelists/opencompute-ready-remote.whitelist	2013-07-26 18:35:33 +0000
@@ -14,13 +14,16 @@
 package
 sleep
 uname
-__ipmi__
+__ipmi_out_of_band__
 ipmi/out_of_band/admin/chassis_info
 ipmi/out_of_band/admin/power_off
 ipmi/out_of_band/admin/power_on
+ipmi/out_of_band/admin/power_cycle
+ipmi/out_of_band/admin/power_reset
+ipmi/out_of_band/admin/power_policy_always_on
+ipmi/out_of_band/admin/power_policy_always_off
+ipmi/out_of_band/admin/power_policy_previous
 ipmi/out_of_band/admin/chassis_self_test
-ipmi/out_of_band/admin/dcmi_sensor_info
-ipmi/out_of_band/admin/dcmi_temp_readings
 ipmi/out_of_band/admin/detailed_sensor_readings
 ipmi/out_of_band/admin/chassis_status
 

=== modified file 'debian/changelog'
--- debian/changelog	2013-07-05 16:43:48 +0000
+++ debian/changelog	2013-07-26 18:35:33 +0000
@@ -1,4 +1,4 @@
-checkbox (0.16.6) UNRELEASED; urgency=low
+checkbox (0.16.6ubuntu1) UNRELEASED; urgency=low
 
   [ Brendan Donegan ]
   * plugins/launchpad_report.py - Don't include attachments which have a status
@@ -16,7 +16,10 @@
     - Open the log using the 'rb' flag. This prevents python from throwing
       a UnicodeDecodeError.
 
- -- Brendan Donegan <brendan.donegan@xxxxxxxxxxxxx>  Fri, 28 Jun 2013 15:02:58 +0100
+  [ Jeff Marcom ]
+  * jobs/ipmi_out_of_band.txt.in - added new out of band ipmi tests
+
+ -- Jeff Marcom <jeff.marcom@xxxxxxxxxxxxx>  Fri, 26 Jul 2013 13:34:24 -0400
 
 checkbox (0.16.5) saucy; urgency=low
 

=== removed file 'jobs/ipmi.txt.in'
--- jobs/ipmi.txt.in	2013-07-08 15:22:08 +0000
+++ jobs/ipmi.txt.in	1970-01-01 00:00:00 +0000
@@ -1,127 +0,0 @@
-plugin: attachment
-name: ipmi/out_of_band/admin/chassis_info
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD fru -C3
-description:
- Retrieve chassis model and manufacturer information.
-
-plugin: shell
-name: ipmi/out_of_band/admin/dcmi_info
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmiutil dcmi -N $OC_IPMI_TARGET $OC_IPMI_ADMIN $OC_IPMI_ADMIN_PASSWORD
-description:
- Get DCMI capabilities with Admin User
-
-plugin: shell
-name: ipmi/user/dcmi_info
-requires: package.name == 'ipmiutil'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_USERNAME OC_IPMI_PASSWORD
-command: ipmiutil dcmi -N $OC_IPMI_TARGET $OC_IPMI_USERNAME $OC_IPMI_PASSWORD
-description:
- Get DCMI capabilities with User
-
-plugin: shell
-name: ipmi/operator/dcmi_info
-requires: package.name == 'ipmiutil'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_OPERATOR OC_IPMI_OPERATOR_PASSWORD
-command: ipmiutil dcmi -N $OC_IPMI_TARGET $OC_IPMI_OPERATOR $OC_IPMI_OPERATOR_PASSWORD
-description:
- Get DCMI capabilities with Operator
-
-plugin: shell
-name: ipmi/out_of_band/admin/check_power_on
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD chassis power status -C3 | grep -q "on"
-description:
- Retrieve Chassis Status information with Admin credentials
-
-plugin: shell
-name: ipmi/out_of_band/admin/check_power_off
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD chassis power status -C3 | grep -q "off"
-description:
- Retrieve Chassis Status information with Admin credentials
-
-plugin: shell
-name: ipmi/out_of_band/admin/power_on
-requires: package.name == 'ipmitool'
-depends: ipmi/out_of_band/admin/check_power_off
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD chassis power on -C3
-description:
- Power on server via BMC with Admin credentials
-
-plugin: shell
-name: ipmi/out_of_band/admin/power_off
-requires: package.name == 'ipmitool'
-depends: ipmi/out_of_band/admin/check_power_on
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD chassis power off -C3
-description:
- Power off server via BMC with Admin credentials
-
-plugin: shell
-name: ipmi/out_of_band/admin/chassis_self_test
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD chassis selftest -C3
-description:
- Run chassis BMC self test with Admin credentials
-
-plugin: shell
-name: ipmi/out_of_band/admin/dcmi_sensor_info
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD dcmi sensors -C3
-description:
- Retrieve sensor info via dcmi 
-
-plugin: shell
-name: ipmi/out_of_band/admin/dcmi_temp_readings
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD dcmi get_temp_reading -C3
-description:
- Retrieve chassis temperature readings via dcmi
-
-plugin: shell
-name: ipmi/out_of_band/admin/detailed_sensor_readings
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD sensor -C3
-description:
- Retrieve detailed chassis sensor readings
-
-plugin: shell
-name: ipmi/out_of_band/admin/chassis_status
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_ADMIN OC_IPMI_ADMIN_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_ADMIN -P $OC_IPMI_ADMIN_PASSWORD chassis status -C3
-description:
- Retrieve Chassis Status information with Admin credentials
-
-plugin: shell
-name: ipmi/user/chassis_status
-requires: package.name == 'ipmitool'
-user: root
-environ: OC_IPMI_TARGET OC_IPMI_USER OC_IPMI_USER_PASSWORD
-command: ipmitool -I lanplus -H $OC_IPMI_TARGET -U $OC_IPMI_USER -P $OC_IPMI_USER_PASSWORD chassis status -C3
-description:
- Retrieve Chassis Status information with User credentials

=== added file 'jobs/ipmi_out_of_band.txt.in'
--- jobs/ipmi_out_of_band.txt.in	1970-01-01 00:00:00 +0000
+++ jobs/ipmi_out_of_band.txt.in	2013-07-26 18:35:33 +0000
@@ -0,0 +1,151 @@
+plugin: attachment
+name: ipmi/in_band/admin/chassis_info
+requires: package.name == 'ipmitool'
+user: root
+command: ipmitool fru -C3
+description:
+ Retrieve chassis model and manufacturer information.
+
+plugin: attachment
+name: ipmi/out_of_band/admin/chassis_info
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD fru -C3
+description:
+ Retrieve chassis model and manufacturer information.
+
+plugin: shell
+name: ipmi/out_of_band/admin/check_power_on
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis power status -C3 | grep -q "on"
+description:
+ Retrieve Chassis Status information with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/check_power_off
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis power status -C3 | grep -q "off"
+description:
+ Retrieve Chassis Status information with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_on
+requires: package.name == 'ipmitool'
+depends: ipmi/out_of_band/admin/check_power_off
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis power on -C3; retval=$?; sleep 30; exit $retval
+description:
+ Power on server via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_off
+requires: package.name == 'ipmitool'
+depends: ipmi/out_of_band/admin/check_power_on
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis power off -C3; retval=$?; sleep 30; exit $retval
+description:
+ Power off server via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_reset
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis power reset -C3; retval=$?; sleep 30; exit $retval
+description:
+ Power reset server via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_cycle
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis power cycle -C3; retval=$?; sleep 30; exit $retval
+description:
+ Power cycle server via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_policy_always_on
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis policy always-on -C3
+description:
+ Set server power policy to always on via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_policy_always_off
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis policy always-off -C3
+description:
+ Set server power policy to always off via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/power_policy_previous
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis policy previous -C3
+description:
+ Set server power policy to previous via BMC with Admin credentials
+
+plugin: shell
+name: ipmi/in_band/admin/chassis_self_test
+requires: package.name == 'ipmitool'
+user: root
+command: ipmitool chassis selftest -C3
+description:
+ Run chassis BMC self test with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/chassis_self_test
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis selftest -C3
+description:
+ Run chassis BMC self test with Admin credentials
+
+plugin: shell
+name: ipmi/in_band/admin/detailed_sensor_readings
+requires: package.name == 'ipmitool'
+user: root
+command: ipmitool sensor -C3
+description:
+ Retrieve detailed chassis sensor readings
+
+plugin: shell
+name: ipmi/out_of_band/admin/detailed_sensor_readings
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD sensor -C3
+description:
+ Retrieve detailed chassis sensor readings
+
+plugin: shell
+name: ipmi/in_band/admin/chassis_status
+requires: package.name == 'ipmitool'
+user: root
+command: ipmitool chassis status -C3
+description:
+ Retrieve Chassis Status information with Admin credentials
+
+plugin: shell
+name: ipmi/out_of_band/admin/chassis_status
+requires: package.name == 'ipmitool'
+user: root
+environ: IPMI_TARGET IPMI_ADMIN IPMI_ADMIN_PASSWORD
+command: ipmitool -I lanplus -H $IPMI_TARGET -U $IPMI_ADMIN -P $IPMI_ADMIN_PASSWORD chassis status -C3
+description:
+ Retrieve Chassis Status information with Admin credentials
+

=== modified file 'jobs/local.txt.in'
--- jobs/local.txt.in	2013-07-05 21:44:58 +0000
+++ jobs/local.txt.in	2013-07-26 18:35:33 +0000
@@ -117,12 +117,12 @@
   shopt -s extglob
   cat $CHECKBOX_SHARE/jobs/install.txt?(.in)
 
-name: __ipmi__
+name: __ipmi_out_of_band__
 plugin: local
-_description: IPMI tests
+_description: IPMI out of band tests
 command:
   shopt -s extglob
-  cat $CHECKBOX_SHARE/jobs/ipmi.txt?(.in)
+  cat $CHECKBOX_SHARE/jobs/ipmi_out_of_band.txt?(.in)
 
 name: __keys__
 plugin: local

=== modified file 'po/POTFILES.in'
--- po/POTFILES.in	2013-07-05 21:44:58 +0000
+++ po/POTFILES.in	2013-07-26 18:35:33 +0000
@@ -19,7 +19,7 @@
 [type: gettext/rfc822deb] jobs/info.txt.in
 [type: gettext/rfc822deb] jobs/input.txt.in
 [type: gettext/rfc822deb] jobs/install.txt.in
-[type: gettext/rfc822deb] jobs/ipmi.txt.in
+[type: gettext/rfc822deb] jobs/ipmi_out_of_band.txt.in
 [type: gettext/rfc822deb] jobs/keys.txt.in
 [type: gettext/rfc822deb] jobs/led.txt.in
 [type: gettext/rfc822deb] jobs/local.txt.in

=== modified file 'setup.cfg'
--- setup.cfg	2013-07-05 21:44:58 +0000
+++ setup.cfg	2013-07-26 18:35:33 +0000
@@ -25,7 +25,7 @@
          "jobs/info.txt.in",
          "jobs/input.txt.in",
          "jobs/install.txt.in",
-         "jobs/ipmi.txt.in",
+         "jobs/ipmi_out_of_band.txt.in",
          "jobs/keys.txt.in",
          "jobs/led.txt.in",
          "jobs/local.txt.in",