openerp-chinese-team team mailing list archive

["jeff.wang" <wjfonhand@xxxxxxxxxxx>]

Hi Eric,

  Thank you for your understanding. 
  After discuss with some chinese developers, we found your solution come from the tool/amount_to_text_en.py . Actrually I didn't master why openerp design this function like that, how it can be used in current system for English and France, and how to extend this method to other languages.

  I fully agree you that this  rmb_upper (or name it ammount_to_text) method maybe used in many other modules, so maybe we should collect these types of functions as library and carefully put some of them into module l10n_cn.

  I will never remove your code for you are almost the first contributor besides people from shine IT. Every contribution, even we keep our right to show personal opinion, are WELCOME ! 

--------------------

By the way, do you mind if we use ???? in this maillist next time ? ????????????????????????????????????

Yours

Jeff Wang 


------------------ Original ------------------
From:  "Eric Caudal"<eric.caudal@xxxxxxxxxxxxxx>;
Date:  Mon, May 21, 2012 05:00 PM
To:  "openerp-chinese-team"<openerp-chinese-team@xxxxxxxxxxxxxxxxxxx>; 

Subject:  Re: [Openerp-chinese-team][Branch~openerp-chinese-team/openerp-china/openerp-china] Rev64: [ADD]library modules with methods to convert digits toChinese characters



                   Hi Jeff,
     Thanks for pointing out the original code: I did not see it maybe     actually because it is in the middle of a module.
     My idea for this module (l10n_cn_library) was not to create a     standard module (this is why there is no __init__ or __openerp__)     but more to gather specific functions that are reusable inside other     module.
     We have to create this function for a customer and could not find     it: this is why I propose this idea of library to share.
     
     For me this is fine not to keep it if you think this is not     compliant with your guidelines.
     Best regards
                          
                                         
                                         Eric CAUDAL, Elico Corp, Shanghai. eric.caudal@xxxxxxxxxxxxxx Cell: + 86 186 2136 1670. Skype: elico.corp Premium Certified Training Partner - OpenERP Ready Partner.                            
               
               http://www.openerp.net.cn                        
                     
     
     On 05/21/2012 02:40 PM, jeff.wang wrote:            Hi Eric,
         
            Thanks for your contribution, but I have to point out, I am         not so agree this module is better than I imagine :)
         
            http://bazaar.launchpad.net/~openerp-chinese-team/openerp-china/openerp-china/view/head:/oecn_account_print/report/rml_parse.py
            
            If you read this source you will find the method _rmb_upper from line 63 to line 96, it was           copied from csdn by Oldrev for account reporting module 2           years ago.  we are satisfied with this 30 line code.
           
             Now you commit a new module, with double 165 lines code           piece (for traditional chinese and simple chinese ?) without           __init__ and __openerp__ defination.  can you explain why and           how it can be used ? 
           
             we know each directory of openrp-china branch will be           publish on apps.openerp.com soon, users will be confuse after           they download this library module I guess.
           
             Again, I want to show my thanks for you collaboration effort           on open source way, let's keep it and make it !     
       
       
       
                  
             Yours
             
             Jeff Wang
           
           
           
           ------------------ Original ------------------
                        From:  "noreply"<noreply@xxxxxxxxxxxxx>;
             Date:  Mon, May 21, 2012 12:17 PM
             To:  "Open ERP               Chinese"<openerp-chinese-team@xxxxxxxxxxxxxxxxxxx>;               
             Subject:  [Openerp-chinese-team]               [Branch~openerp-chinese-team/openerp-china/openerp-china]               Rev64: [ADD] library modules with methods to convert               digits toChinese characters
           
           
           
           ------------------------------------------------------------
           revno: 64
           committer: <elicoidal elicoidal@xxxxxxxxxxx>
           branch nick: openerp-china
           timestamp: Mon 2012-05-21 12:13:50 +0800
           message:
             [ADD] library modules with methods to convert digits to           Chinese characters
           added:
             l10n_cn_library/
             l10n_cn_library/amount_to_text_cn.py
             l10n_cn_library/amount_to_text_cn_digits.py
           
           
           --
           lp:openerp-china
 https://code.launchpad.net/~openerp-chinese-team/openerp-china/openerp-china
           
           Your team Open ERP Chinese is subscribed to branch           lp:openerp-china.
           To unsubscribe from this branch go to https://code.launchpad.net/~openerp-chinese-team/openerp-china/openerp-china/+edit-subscription
           
           _______________________________________________
           Mailing list: https://launchpad.net/~openerp-chinese-team
           Post to     : openerp-chinese-team@xxxxxxxxxxxxxxxxxxx
           Unsubscribe : https://launchpad.net/~openerp-chinese-team
           More help   : https://help.launchpad.net/ListHelp
           
         
       
              
       _______________________________________________ Mailing list: https://launchpad.net/~openerp-chinese-team Post to     : openerp-chinese-team@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~openerp-chinese-team More help   : https://help.launchpad.net/ListHelp

Attachment: 5606A8B0@D0151C23.910ABA4F.png
Description: Binary data