openerp-community-committers team mailing list archive

[Jan Verlaan - Veritos <jverlaan@xxxxxxxxxx>]

I agree with Christophe, at least for me it is the most clear and best 
way to test code proposals in our community before merging into stable.
Comments to merge proposals can be made easily into the merge proposal. 
I admit that for some developers this could be extra work as they have a 
customized system and a patchfile is then much easier to create, but 
more difficult to review by community.

Regards,
Jan

Op 18-11-10 07:13, Christophe CHAUVET (SYLEAM) schreef:
> Hi
>
> Before commiting directly on the branch, i prefer to create a new branch,
> and request a Merge Proposal
>
> Comments ?
>
> Regards,
>
>
> 2010/11/18 Albert Cervera i Areny<albert@xxxxxxxxxxx>
>
> >   I've just created the community addons branch here:
> >
> >
> > https://code.launchpad.net/~openerp-community-committers/openobject-addons/5.0<https://code.launchpad.net/%7Eopenerp-community-committers/openobject-addons/5.0>
> >
> > By now it's plain addons but we all agree we will start merging our branch.
> > Because several fixes have not been applied yet to official branch but
> > they've been in production in several customers for weeks. Some details
> > here:
> >
> > http://www.nan-tic.com/new-branches
> >
> > I'm sure others also have well-tested uncommited patches which you could
> > start committing there.
> >
> > But even before we start with it, maybe we should have some kind of policy
> > for fixes. Do you have some ideas?
> >
> > I think we should only apply bugfixes and I'd suggest that it should be a
> > must that each commit has its related bug report in associated with it. This
> > way we ensure it's easier for OpenERP sa (and the rest of us) to understand
> > what's going on in the branch and it makes it clearer that it's not a fork
> > but a branch with fixes not yet in the official branch.
> >
> > Comments?
> >
> >
> > --
> >
> > Albert Cervera i Areny
> >
> > http://www.NaN-tic.com
> >
> > OpenERP Partners<http://www.NaN-tic.com>
> >
> > Tel: +34 937 253 707
> >
> > http://twitter.com/albertnan
> >
> > http://albert-nan.blogspot.com
> >
> > http://angel-nan.blogspot.com<http://albert-nan.blogspot.com>
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~openerp-community-committers<https://launchpad.net/%7Eopenerp-community-committers>
> > Post to     : openerp-community-committers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~openerp-community-committers<https://launchpad.net/%7Eopenerp-community-committers>
> > More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community-committers
> Post to     : openerp-community-committers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community-committers
> More help   : https://help.launchpad.net/ListHelp