openerp-community-reviewer team mailing list archive

[Niels Huylebroeck <nh@xxxxxxxxxx>]

I'm greenlighting Joao membership as community reviewer, at this point we
can still use some more members and to me it certainly looks like his
contributions have been valuable and qualitative.

I would just like to mention to Joao that our aim is to keep company
specific naming out of the picture as much as possible as to
allow/encourage participation from other developers.
In short the names of branches should reflect more the add/fixed
functionality instead of focusing who is doing it.

A bit of a tangent here:

I would like to point out to everyone here that it's also possible to push
branches in a teams name (if you are a member of this team) by using push
locations such as :
bzr push
lp:~openerp-community-review/openobject-addons/7.0-fixing-bug-111111-with-orm

The url consists out of following parts:
lp:~<team-name>/<project-name>/<name-of-your-branch>

Pushing branches on teams instead of on your own name allows other people
in the same team to commit directly onto your branch, this could speed up
little nitpicking fixes as I personally don't like to read and point out
nits on the launchpad merge proposal page, I'd rather just open the code on
my computer in my favorite editor (which helps me to find errors) and
commit those nits directly.

It's the difference between talking about improving the code and actually
improving the code.
With the limited time we all have considering our day-time work we all want
to save as much time as we can, for me it would help a lot with
reviewing/improving code faster.

Regards,
Niels


2013/3/12 Maxime Chambreuil <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>

> Hello,
>
> These past weeks, I have assigned Joao some merge proposals to review.
> Here is the list:
>
> https://code.launchpad.net/~jonatan-cloutier/openerp-canada/fix6.1/+merge/152030
>
> https://code.launchpad.net/~jonatan-cloutier/openerp-canada/updateRate70/+merge/152428
>
> https://code.launchpad.net/~jonatan-cloutier/openerp-canada/updateRate61/+merge/152427
>
> https://code.launchpad.net/~openerp-canada/openerp-canada/fix_osv.Model/+merge/152530
>
> with few new contributions :
>
> https://code.launchpad.net/~joao-gama/partner-contact-management/6.1-partner_auto_salesman/+merge/152002
>
> https://code.launchpad.net/~joao-gama/partner-contact-management/partner_auto_salesman/+merge/151985
>
> and his active branches :
> https://code.launchpad.net/~joao-gama
>
> If you need further reviews from him, please set him as the reviewer (I am
> running out of MPs).
>
> Thank you very much for your time.
>
> --
> Maxime Chambreuil
> 1-514-276-5468 #126
>
> ------------------------------
> Hello Maxime,
>
>
> After having a look to what has been achieve by Joao, I think he clearly
> deserve his place in the community reviewer team. As we do not really have
> clear rules on who to admit and on which basis, could I suggest that he
> starts making some review within the next days (even if not in the team),
> so it let everyone to agree on his membership ?
>
> I think this should be a good way of integrating the team : making review
> first and then ask to be part of it. Not to put barrier, I know I can trust
> you, but more to starts putting some organization. What do you think ?
>
> Other opinion ?
>
> Best regards,
>
>
> Joël
>
>
>
>
> Le 12 févr. 2013 à 20:16, Maxime Chambreuil <
> maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx> a écrit :
>
> Dear Reviewers,
>
> I would like to recommend my colleague Joao Alfredo Gama Batista as a new
> member of the OpenERP Community Reviewer team.
>
> You will find Joao's Launchpad page here :
> https://launchpad.net/~joao-gama
>
> and his Git Hub page here :
> https://github.com/joaoalf
>
> Joao is our most experienced OpenERP developer at Savoir-faire Linux and a
> better resource than me for the OpenERP community to participate in the
> code review and merge effort.
>
> Thank you very much for your time reviewing this proposal.
>
> Have a great day.
> --
> Maxime Chambreuil
> 1-514-276-5468 #126
> --
> Mailing list: https://launchpad.net/~openerp-community-reviewer
> Post to     : openerp-community-reviewer@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community-reviewer
> More help   : https://help.launchpad.net/ListHelp
>
>
> --
>
>
> *camptocamp*
> INNOVATIVE SOLUTIONS
> BY OPEN SOURCE EXPERTS
>
> *Joël Grand-Guillaume*
> Division Manager
> Business Solutions
>
> +41 21 619 10 28
> *
> *
> www.camptocamp.com
>
>
>
>
>
>
> --
> Mailing list: https://launchpad.net/~openerp-community-reviewer
> Post to     : openerp-community-reviewer@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community-reviewer
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Niels Huylebroeck
Lead Architect   --   Agaplan
Tel. : +32 (0) 93 95 98 90
Web : http://www.agaplan.eu