openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #00423
Re: lp:~camptocamp/margin-analysis/7.0-port-product_cost_incl_bom-yvr into lp:margin-analysis
Review: Needs Fixing code review, no test
Hi, Yannick, thank you for the migration. Could you please check PEP8 compliance (for example, on depends line, you put an space before : ).
I see you have removed parameters product_uom and bom_properties, replaced by context dictionary values. I'm curious about where these values are set.
Regards.
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_cost_incl_bom-yvr/+merge/190348
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.
References