openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr into lp:margin-analysis

To: mp+190350@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Thu, 10 Oct 2013 20:39:12 -0000
In-reply-to: <20131010122625.22926.35297.launchpad@ackee.canonical.com>
Reply-to: mp+190350@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review, no test

Hi, Yannick, thank you very much for the cleaning.

I wonder, because we have never discussed this before, what is the correct space indentation for XML. In Python it is used 4 spaces. I have seen that you have used 2 spaces. I see this a little short, but I would like to know the opinion of others.

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr/+merge/190350
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.

References

lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr into lp:margin-analysis
From: Yannick Vaucher @ Camptocamp, 2013-10-10