openerp-community-reviewer team mailing list archive

[Nhomar - Vauxoo <nhomar@xxxxxxxxx>]

Review: Needs Fixing

Hello.

The approach to build a report directly to xls is really good.

About the concept:

IMHO if I have 2 different algorithms to compute 2 different reports they become them really hard to mantain

BTW i know the power of xlwt and I respect the fact of use it, but this MP should be documented as:

New "XLS" Reports using the algorithm present in the webkit reports, because it is not the same report they are different ones.

With this change I dont have any problem with this merge.

About the technology:

IOH, I am curious, Why is the reason you didn't simply convert the *webkit to excel?

About the technical part.

THis modules depend of report_xls which is not available in any community/managed branch, can you make an MP for this module and we merge first this and after that put this reports?

I didn't test yet, We will IMHO this is a cool feature (even if i hate excel <Joke>).

Regards, and really thanks for contribute.
-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit_xls/+merge/192246
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.