openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #00792
Re: lp:~vauxoo/account-financial-report/7.0-report_webkit_afr-_data_dev-jorge into lp:account-financial-report
Review: Needs Fixing
Hi,
With the lines in <table><td>, you'll have problems with lines being cut or hidden between pages (that's a wkhtmltopdf bug, see comment #9 and #11 of https://code.google.com/p/wkhtmltopdf/issues/detail?id=566).
That's why we used solely <div> in our reports: we use "<div>" elements with the "display" css property (with values "table", "table-row", "table-cell", ...).
Example in our reports:
http://bazaar.launchpad.net/~account-report-core-editor/account-financial-report/7.0/view/head:/account_financial_report_webkit/report/templates/account_report_partners_ledger.mako#L26
And the css:
http://bazaar.launchpad.net/~account-report-core-editor/account-financial-report/7.0/view/head:/account_financial_report_webkit/data/financial_webkit_header.xml#L71
--
https://code.launchpad.net/~vauxoo/account-financial-report/7.0-report_webkit_afr-_data_dev-jorge/+merge/192050
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.
References