openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing

Sorry to insist about the module/models name, but I think that it's very important to define them now that the module doesn't exists yet, because later we can't rename it blindly without disturbing users that have previously install it.

IMHO put the names on the first "namespace" level is an error, because:

* Generates an inconsistency on regular module naming conventions.
* Leads integrators (and advanced users that use technical name) to confussion.
* Can provoke conflicts with other models (if everyone uses the same schema, there will be a moment where two model names coincides).
* When developing, it's easier to remember with the regular schema.
* If we can make it ordered, let's make it!

One example of the mess provoked by the names are in account_payment and its extension: models are called payment.order, payment.order.line and so on instead of account.payment.order and so on with no known reason.

I proposed previously account_advanced_budget, but if it doesn't reflect correctly the module, it can be called account_alt_budget or account_extended_budget, and please also take in account this for model names ('account.alt_budget' instead of 'budget', for instance).

Regards.
-- 
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-budget-migr/+merge/162802
Your team Account Core Editors is subscribed to branch lp:account-budgeting.