openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Hi there,

I don't really understand what is your problem with the 'budget' name for the module.

> Sorry to insist about the module/models name, but I think that it's very
> important to define them now that the module doesn't exists yet, because later
> we can't rename it blindly without disturbing users that have previously
> install it.

We already use it in production for several customers. Though, I could agree to change the name if it was for good reasons, but here I can't find them valid:

> 
> IMHO put the names on the first "namespace" level is an error, because:
> 
> * Generates an inconsistency on regular module naming conventions.

Doing a 'ls' in the OpenERP official addons, I see much modules with 1 part (what you call first namespace level):
account, analytic, anonymization, association, audittrail, board, contacts, crm, delivery, document, edi, event, fetchmail, fleet, hr, idea, knowledge, lunch, mail, marketing, membership, mrp, note, pad, plugin, portal, process, procurement, product, project, purchase, resource, sale, share, stock, subscription, survey, test, warning

So, what are regular module naming conventions?


> * Leads integrators (and advanced users that use technical name) to
> confussion.
As soon as 2 modules contains 'budget', it brings confusion, that's why the manifest is there to explain the purpose of the module.

> * Can provoke conflicts with other models (if everyone uses the same schema,
> there will be a moment where two model names coincides).

That's why I respected the naming conventions for the models, that is, I named the main model 'budget.budget' instead of 'budget'. 

> * When developing, it's easier to remember with the regular schema.

That is the regular schema. The module name is 'budget' and the model is 'budget.budget' like we have 'account' and 'account.account'.

> * If we can make it ordered, let's make it!
I should have a different notion of ordering. It is already ordered from my viewpoint.

> 
> One example of the mess provoked by the names are in account_payment and its
> extension: models are called payment.order, payment.order.line and so on
> instead of account.payment.order and so on with no known reason.

You speak about a problem which is unrelated to this module, 'account_payment' does not respect the naming convention, while 'budget' respects it.
 
The proposition of analytic_budget is not necessarily better: the budget is crossing between account and analytics. We'll also have extension modules to the budget like 'budget_report' and so on. I don't any valid reason why the budget could not be a top level module.
-- 
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-budget-migr/+merge/162802
Your team Account Core Editors is subscribed to branch lp:account-budgeting.