← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~therp-nl/ocb-addons/lp1220716 into lp:ocb-addons

 

I'm not sure either.

Don't you think it's better to revert the change to get the test suite
green again and merge again when we are sure?


On Mon, Nov 4, 2013 at 10:07 AM, Holger Brunn (Therp) <hbrunn@xxxxxxxx>wrote:

> I'm not so sure if this is a problem with the code rather than with the
> test.
>
> The change introduced is that we don't silently ignore non-draft purchase
> orders any more, which seems correct to me. Shouldn't the test cancel all
> related pickings before cancelling the requisition?
>
> In any case, given that this is already merged, you should open a bug
> report against ocb-addons/7.0 to for simpler reference and fixing of the
> issue.
> --
> https://code.launchpad.net/~therp-nl/ocb-addons/lp1220716/+merge/184072
> You are reviewing the proposed merge of lp:~therp-nl/ocb-addons/lp1220716
> into lp:ocb-addons.
>

-- 
https://code.launchpad.net/~therp-nl/ocb-addons/lp1220716/+merge/184072
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.


References