openerp-community-reviewer team mailing list archive

[Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>]

After my split I have around 140 ligne of python in exception_rule and around 40 in sale_exception so I really think it's worth to split it because we will avoid to duplicate the 140 ligne in every module for nothing, it's not a lot but it's always better to no duplicate the code (on improvement improve all module). Moreover we use the same pop-up wizard in sale_exception and purchase_exception so it the same interface for the end user.

Here is my work : http://bazaar.launchpad.net/~sebastien.beau/e-commerce-addons/e-commerce-addons-split-sale-exception/view/head:/sale_exceptions/sale.py
(not ready to be merge yet, I have to be sure that I do not miss any improvement done by guewen here https://code.launchpad.net/~extra-addons-commiter/e-commerce-addons/7.0)



-- 
https://code.launchpad.net/~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge/+merge/193567
Your team OpenERP Community Reviewer is subscribed to branch lp:~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge.