← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet/7.0

 

Review: Approve code review

Thanks! What happens when you run this branch on standard OpenERP branches? Maybe add a disclaimer about this in the module description.

Otherwise approved. I noticed that some column names changed in hr_holiday_rel but this should be alright as it concerns a transient model.



-- 
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet/7.0.


References