openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix into lp:ocb-addons/6.1

To: mp+185327@xxxxxxxxxxxxxxxxxx
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Mon, 11 Nov 2013 14:05:44 -0000
In-reply-to: <20130912175223.6273.90427.launchpad@ackee.canonical.com>
Reply-to: mp+185327@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Same comments than: https://code.launchpad.net/~florian-dacosta/ocb-addons/7.0_purchase_line_partner_fix/+merge/185331/comments/449347 :

l.11 The context must be propagated in the read.
l.24 No mutable in keyword argument: replace "c={}" by "c=None".

l.23-24 Indentation is dubious, see http://www.python.org/dev/peps/pep-0008/#indentation
-- 
https://code.launchpad.net/~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix/+merge/185327
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.