openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review, no test

Hi, Thomas, thank you very much for the changes. You can also change on the manifest file (__openerp__.py) the word demo instead demo_xml, remove update_xml, and change 'data' instead 'init_xml'.

Functionally speaking, I see only one problem: when you duplicate a partner, the code is kept on both partners, so you must inherit copy method to fix this. This can be more or less (please check, because I haven't tested and write it very quickly):

    def copy(self, cr, uid, ids, default=None, context=None):
        if default is None:
            default = {}
        default['ref'] = self.pool.get('ir.sequence').get(cr, uid, 'res.partner', context=context)
        return super(res_partner, self).copy(cr, uid, ids, default, context=context)

Regards.
-- 
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.