openerp-community-reviewer team mailing list archive

["Vincent Renaville@camptocamp" <vincent.renaville@xxxxxxxxxxxxxx>]

Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit into lp:partner-contact-management.

Requested reviews:
  Partner and Contact Core Editors (partner-contact-core-editors)
  Yannick Vaucher @ Camptocamp (yvaucher-c2c): code

For more details, see:
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit/+merge/195092

Hello,

I do a resubmit, I think it's more clear now.

Vincent
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit/+merge/195092
Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit into lp:partner-contact-management.

=== modified file 'partner_firstname/partner_view.xml'
--- partner_firstname/partner_view.xml	2013-10-01 11:32:16 +0000
+++ partner_firstname/partner_view.xml	2013-11-13 16:20:40 +0000
@@ -32,10 +32,18 @@
           </group>
         </field>
         <!-- Add firstname and last name in inner contact form of child_ids -->
-        <xpath expr="//form[@string='Contact']/sheet/div/h1/field[@name='name']" position="after">
-            <field name="lastname"/>
+        <xpath expr="//form[@string='Contact']/sheet/div" position="after">
+           <group attrs="{'invisible': [('is_company', '=', True)]}">
+            <field name="lastname" attrs="{'required': [('is_company', '=', False)]}"/>
             <field name="firstname"/>
-        </xpath>
+           </group> 
+        </xpath>
+        <xpath expr="//form[@string='Contact']/sheet/div/h1" position="after">
+           <field name="is_company" on_change="onchange_type(is_company)" class="oe_inline"/>
+           <label for="is_company" string="Is a Company?"/>)
+        </xpath>
+
+
       </field>
     </record>