openerp-community-reviewer team mailing list archive

["Vincent Renaville@camptocamp" <vincent.renaville@xxxxxxxxxxxxxx>]

Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/hr-timesheet/full-fill-timesheet-account-type-vre into lp:hr-timesheet.

Requested reviews:
  Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review, no tests
  Yannick Vaucher @ Camptocamp (yvaucher-c2c)
Related bugs:
  Bug #1250085 in HR - Timesheet Management: "full fill timesheet account type "
  https://bugs.launchpad.net/hr-timesheet/+bug/1250085

For more details, see:
https://code.launchpad.net/~camptocamp/hr-timesheet/full-fill-timesheet-account-type-vre/+merge/196123

change type from normal to contract to match project linked analytic account instead of standard analytic account
-- 
https://code.launchpad.net/~camptocamp/hr-timesheet/full-fill-timesheet-account-type-vre/+merge/196123
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet.

=== modified file 'hr_timesheet_fulfill/wizard/timesheet_fulfill.py'
--- hr_timesheet_fulfill/wizard/timesheet_fulfill.py	2013-05-02 13:51:52 +0000
+++ hr_timesheet_fulfill/wizard/timesheet_fulfill.py	2013-11-21 14:45:19 +0000
@@ -43,7 +43,7 @@
         'nb_hours': fields.float('Hours per Day', digits=(2, 2), required=True),
         'analytic_account_id': fields.many2one('account.analytic.account',
                                'Analytic Account', required=True,
-                               domain="[('type', '=', 'normal'),"
+                               domain="[('type', '=', 'contract'),"
                                       "('state', '!=', 'pending'),"
                                       "('state', '!=', 'close')]"),
         'task_id':fields.many2one('project.task', 'Task', required=False)