← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/hr-timesheet/full-fill-timesheet-account-type-vre into lp:hr-timesheet

To: "Vincent Renaville@camptocamp" <vincent.renaville@xxxxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Wed, 18 Dec 2013 10:39:02 -0000
In-reply-to: <20131121144557.10765.94943.launchpad@ackee.canonical.com>
Reply-to: mp+196123@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

As Pedro suggested, ('type', '<>', 'view') would be more generic and seems to fits the requirements you described.
-- 
https://code.launchpad.net/~camptocamp/hr-timesheet/full-fill-timesheet-account-type-vre/+merge/196123
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet.

References

lp:~camptocamp/hr-timesheet/full-fill-timesheet-account-type-vre into lp:hr-timesheet
From: Vincent Renaville@camptocamp, 2013-11-21