openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review, no test

Hi, Stéphane, thank you very much for the improvement. Apart from the problem said by Joël, I think you can improve the code putting this:

if not tax_code_ids:
    # if we could not match no tax code template name,
    # try to match on tax code template code, if any
    tax_code_code = tax_code_template.code
    if tax_code_code:
        tax_code_ids = tax_codes.search(cr, uid, [
              ('code', '=', tax_code_code),
              ('company_id', '=', wizard.company_id.id)
              ])
if tax_code_ids:
    tax_code_template_mapping[
        tax_code_template.id] = tax_code_ids[0]

Regards.
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_chart_update_tac_code_code/+merge/195627
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.