openerp-community-reviewer team mailing list archive

[Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>]

Stéphane Bidoul (Acsone) has proposed merging lp:~acsone-openerp/account-financial-tools/account_chart_update_tac_code_code into lp:account-financial-tools.

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_chart_update_tac_code_code/+merge/195627

Hi,

Here is a small improvement to account_chart_update.

When a tax_code cannot be matched by name, attempt to match by code if one exists.

Thanks for this excellent tool.

Best regards,

-sbi
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_chart_update_tac_code_code/+merge/195627
Your team Account Core Editors is requested to review the proposed merge of lp:~acsone-openerp/account-financial-tools/account_chart_update_tac_code_code into lp:account-financial-tools.

=== modified file 'account_chart_update/wizard/wizard_chart_update.py'
--- account_chart_update/wizard/wizard_chart_update.py	2013-10-18 16:44:19 +0000
+++ account_chart_update/wizard/wizard_chart_update.py	2013-11-18 16:16:50 +0000
@@ -270,6 +270,18 @@
             if tax_code_ids:
                 tax_code_template_mapping[
                     tax_code_template.id] = tax_code_ids[0]
+            else:
+                # if we could not match no tax code template name, 
+                # try to match on tax code template code, if any 
+                tax_code_code = tax_code_template.code
+                if tax_code_code:
+                    tax_code_ids = tax_codes.search(cr, uid, [
+                        ('code', '=', tax_code_code),
+                        ('company_id', '=', wizard.company_id.id)
+                    ])
+                    if tax_code_ids:
+                        tax_code_template_mapping[
+                            tax_code_template.id] = tax_code_ids[0]
 
     def _map_account_template(self, cr, uid, wizard, account_template_mapping, account_template, context=None):
         """

=== modified file 'account_credit_control/security/ir.model.access.csv'
--- account_credit_control/security/ir.model.access.csv	2013-07-12 11:57:49 +0000
+++ account_credit_control/security/ir.model.access.csv	2013-11-18 16:16:50 +0000
@@ -18,4 +18,5 @@
 "account_credit_control.ir_model_access_289",0,0,"group_account_credit_control_info","credit_control_info_level","account_credit_control.model_credit_control_policy_level",1,0
 "account_credit_control.ir_model_access_290",0,0,"account.group_account_user","credit_control_fin_user_line","account_credit_control.model_credit_control_line",1,0
 "account_credit_control.ir_model_access_291",0,0,"account.group_account_invoice","credit_control_fin_invoice_line","account_credit_control.model_credit_control_line",1,0
-"account_credit_control.ir_model_access_292",1,1,"account.group_account_manager","credit_control_fin_manager_line","account_credit_control.model_credit_control_line",1,1
\ No newline at end of file
+"account_credit_control.ir_model_access_292",1,1,"account.group_account_manager","credit_control_fin_manager_line","account_credit_control.model_credit_control_line",1,1
+"account_credit_control.ir_model_access_293",0,0,"portal.group_portal","credit_control_line_portal","account_credit_control.model_credit_control_line",1,0
\ No newline at end of file