openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #01732
Re: lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools
Review: Needs Information
Hi,
About the debate on "init" function :
Why not doing the following :
1/ keep the code :
- _defaults [...]
- def _allow_date_always_active [...]
- _constraints [...]
2/ remove the code :
- def init [...]
the init function only does a mass edit, it isn't ? So it's possible for admin user to install and use that module ?
https://www.openerp.com/apps/7.0/mass_editing/ // lp:server-env-tools/7.0
Maybe it's better because mass_editing use orm (I guess) so changing a value will use on_change, constraint, write functions + check right access + use context etc...
the init function only does a hard request in database.
Otherwise, thanks a lot for this module, very usefull.
Regards.
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/196398
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.
References