openerp-community-reviewer team mailing list archive

[Nicolas JEUDY <njeudy@xxxxxxxxxxxxxxx>]

Ok think i Did not push m'y l'astrologie révision Will Check this today

Le samedi 30 novembre 2013, Stefan Rijnhart (Therp) a écrit :

> Review: Needs Fixing
>
> Line 528 still contains the old module name. I think this means that the
> code does not get loaded.
>
> In the lines where you changed exclude into include, you are still
> overwriting the existing object references with the result of the include.
> I find this confusing. Even if it is guaranteed that the same reference is
> returned, it is a useless operation.
>
> --
>
> https://code.launchpad.net/~0k.io/web-addons/7.0_web_m2o_enhanced_proposal/+merge/195518
> Your team 0k.io is subscribed to branch lp:~
> 0k.io/web-addons/7.0_web_m2o_enhanced_proposal.
>


-- 
Nicolas JEUDY

Expert Technique et Fonctionnel Système d'Information
TUXSERVICES

22 rue du seminaire - 25170 Pelousey
e-mail : njeudy@xxxxxxxxxxxxxxx
mob. : +33 (0)6 28 95 36 64
http://www.tuxservices.com

https://code.launchpad.net/~0k.io/web-addons/7.0_web_m2o_enhanced_proposal/+merge/195518
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.