openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows

To: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 04 Dec 2013 16:06:38 -0000
In-reply-to: <20131129152826.24899.91030.launchpad@ackee.canonical.com>
Reply-to: mp+196749@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

l.213 spelling mistake Dinamically -> Dynamically
__openerp__.py is a dictionary, use pep8 style: 4 space indentation and move 'name' to its own line
l.126-137 Would be nicer if these were imported from openerp: openerp.osv, openerp.tools.translate

-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749
Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows.

References

lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows
From: Leonardo Pistone @ camptocamp, 2013-11-29