openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Approve

Hi Etienne,

thanks for the follow up! I believe the interpretation of 'bla@xxxxx' as a separate emailaddress is correct as RFC822 mentions that strings (like the display name) containing the character '@' should be enclosed in the ascii quote character '"', which is not the case here.

You may like to compress the code using a list comprehension like 

    return [address[1] for address in getaddresses([text])]

but if you don't that is fine too. Approved.



-- 
https://code.launchpad.net/~hirt/ocb-addons/6.1_fix_mailaddress-parsing/+merge/194030
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.