openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack into lp:openerp-fiscal-rules.

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack/+merge/199144

Follows https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918/+merge/197376

Since Raphaël stated that the context being mutated in kwargs is not necessary [0], I propose to revert the change.

Note that the current code is failing is some conditions, when a 'uid' key is present in the context for instance.

[0] https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918/+merge/197376/comments/458163
-- 
https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack/+merge/199144
Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack into lp:openerp-fiscal-rules.

=== modified file 'account_fiscal_position_rule_sale/sale.py'
--- account_fiscal_position_rule_sale/sale.py	2013-12-04 07:52:33 +0000
+++ account_fiscal_position_rule_sale/sale.py	2013-12-16 15:26:04 +0000
@@ -53,14 +53,13 @@
             return result
 
         values = result['value']
-        kwargs = context.copy()
-        kwargs.update({
+        kwargs = {
             'shop_id': context['shop_id'],
             'partner_id': partner_id,
             'partner_invoice_id': values.get('partner_invoice_id', False),
             'partner_shipping_id': values.get('partner_shipping_id', False),
             'context': context
-        })
+        }
         return self._fiscal_position_map(cr, uid, result, **kwargs)
 
     def onchange_address_id(self, cr, uid, ids, partner_invoice_id,