openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

The proposal to merge lp:~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack into lp:openerp-fiscal-rules has been updated.

Description changed to:

Follows https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918/+merge/197376

Since Raphaël stated that the context being mutated in kwargs is not necessary [0], I propose to revert the change.

Note that the current code is failing is some conditions, when a 'uid' key is present in the context for instance.

[0] https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918/+merge/197376/comments/457750

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack/+merge/199144
-- 
https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack/+merge/199144
Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack into lp:openerp-fiscal-rules.