← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~atin81/account-financial-tools/account-financial-tools-7.0 into lp:account-financial-tools

 

Review: Approve code review

logger = logging.getLogger(__name__) is not needed in your methods.
There is already a _logger with the same namespace in the module, you can just replace your logger.debug by _logger.debug

pep8: no space before colons, too long lines

It could be nice if you change that, but I still approve


-- 
https://code.launchpad.net/~atin81/account-financial-tools/account-financial-tools-7.0/+merge/198990
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.


References