← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl

 

Review: Needs Information

Joël,

The "mrp_jit" module uses a different approach: it modifies the condition of the workflow.
Did you do it this way to ensure compatibility when both modules are installed?

I may be wrong but I wonder if the condition on l.152 should not restrict only on 'service' *and* 'buy' so if the 'project_mrp' module is used, the 'produce service' would still be triggered by the scheduler.

-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.


References