openerp-community-reviewer team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

Lots of PEP8 issues to fix

osv.osv is depricated in 6.1, use orm.Model
functions that have context as a parameter need to start with:
    if context is None:
        context = dict()
Many browse calls should have context=context in their parameters, the same applies to other self calls which include context=None in their parameters

Code issues:
purchase_landed_costs/purchase.py:224:65: should be context=context

Minor code issues:
purchase_landed_costs/product.py:23:1: should be importing from openerp.osv
purchase_landed_costs/product.py:24:1: unused import
purchase_landed_costs/product.py:34:132: unnecessary backslash
purchase_landed_costs/product.py:41:131: unnecessary backslash
purchase_landed_costs/purchase.py:23:1: should be importing from openerp.osv
purchase_landed_costs/purchase.py:24:1: should be importing openerp.decimal_precision
purchase_landed_costs/purchase.py:25:1: unused import
purchase_landed_costs/purchase.py:229-236: could be a single statement (val = {'product_id': order_cost.product_id.id, ... }

Spelling:
purchase_landed_costs/stock.py 34:18: costss -> costs
purchase_landed_costs/stock.py 49:18: costss -> costs
purchase_landed_costs/stock.py:52:15:  distrubution -> distribution
purchase_landed_costs/stock.py 65:18: costss -> costs
purchase_landed_costs/stock.py 124:18: costss -> costs
purchase_landed_costs/product.py:44:155: catgory -> category
purchase_landed_costs/purchase.py:68:18: costss -> costs
purchase_landed_costs/purchase.py:102:18: costss -> costs
-- 
https://code.launchpad.net/~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs/+merge/199587
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl/6.1.