openerp-community-reviewer team mailing list archive

[Graeme Gellatly <gdgellatly@xxxxxxxxx>]

Hi sorry, I disagree with 

> functions that have context as a parameter need to start with:
>     if context is None:
>         context = dict()

As per openerp coding guidelines this is not necessary if you are only passing context downstream and not accessing it anywhere in your function.  Convention for some maybe, but not required and ultimately just adds unneeded LOC.

https://doc.openerp.com/6.0/contribute/15_guidelines/coding_guidelines_framework/#the-infamous-context
-- 
https://code.launchpad.net/~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs/+merge/199587
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl/6.1.