openerp-community-reviewer team mailing list archive

[Graeme Gellatly <gdgellatly@xxxxxxxxx>]

LGTM - Only looked at code and only question is - in the original patch tagname = '' was changed to tagname = None - in this proposal that line is removed.  By removing this line is there any follow on effects, specifically thinking about next node behaviour, and where tagname == None yielding n.  I don't know, just worried that removing variable could cause bug, by using previous tagnmae in following loop, although equally so could setting to None.  Seems that variable is referenced on lines 50 and 95 in the following loop
-- 
https://code.launchpad.net/~therp-nl/ocb-server/7.0_lp1188136/+merge/190671
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server.