openerp-community-reviewer team mailing list archive

[Graeme Gellatly <gdgellatly@xxxxxxxxx>]

Review: Disapprove

Hi,

+1 agree with Rafa, looks like new feature which should go in extension module and starts to depart from official and mrp is a module that I imagine must get looked at sooner or later, much like WMS for V8. That said interesting concept. 

Also given that really it is changing the workflow in MO's it feels like it is better implemented there, a bit like purchase double validation.

e.g. Checks some function _confirm_auto - returns True - goes straight to confirmed, returns False goes to a new workflow activity between draft and confirmed - call it draft2 - with a transition on say action_manual_confirm, which just requires updating a view to use that button.

Then the workflow logic functions are fully overridable and can be set on per product, per location, per company, per whatever you like logic you can be bothered configuring.

Also I would like to see some sanity around - not changing the schema - this is not directed at you personally but putting in a function field, whether it is persisted in SQL or not is still a new field on a model.  Maybe others think different but to me any field declared on a model is part of the schema, regardless of whether it is persisted or not.
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp1234004_configurable_auto_confirm_mo/+merge/189005
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.