openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls into lp:openerp-reporting-engines

To: mp+199983@xxxxxxxxxxxxxxxxxx
From: Graeme Gellatly <gdgellatly@xxxxxxxxx>
Date: Fri, 03 Jan 2014 06:38:34 -0000
In-reply-to: <20131223220824.10778.85645.launchpad@ackee.canonical.com>
Reply-to: mp+199983@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM, mostly a style and documentation refresh.  Just one meaningful change which looks all good.  Only comment is any reason for not importing

from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT as DT_FORMAT
-- 
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls/+merge/199983
Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls into lp:openerp-reporting-engines.

Follow ups

Re: lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls into lp:openerp-reporting-engines
From: Luc De Meyer (Noviat), 2014-01-06

References

lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls into lp:openerp-reporting-engines
From: Luc De Meyer (Noviat), 2013-12-23