openerp-community-reviewer team mailing list archive

["Luc De Meyer \(Noviat\)" <luc.demeyer@xxxxxxxxx>]

Graeme,

Thanks for the feedback.

While looking into the code to add your " from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT" improvement, I also remarked a bug in the XLSs footer datetime stamp.
In the current version, the XLS footer datetime stamp is created at  _init_ time whereas it should be at XLS creation time). 
I have made a new merge proposal which replaces my previous merge and also fixes the datetime stamp bug, cf. lp:~luc-demeyer/openerp-reporting-engines/datetime-fix-report_xls

Regards,
Luc

-----Original Message-----
From: bounces@xxxxxxxxxxxxx [mailto:bounces@xxxxxxxxxxxxx] On Behalf Of Graeme Gellatly
Sent: vrijdag 3 januari 2014 7:39
To: mp+199983@xxxxxxxxxxxxxxxxxx
Subject: Re: [Merge] lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls into lp:openerp-reporting-engines

Review: Approve

LGTM, mostly a style and documentation refresh.  Just one meaningful change which looks all good.  Only comment is any reason for not importing

from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT as DT_FORMAT
-- 
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls/+merge/199983
You are the owner of lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls.


https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls/+merge/199983
Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~luc-demeyer/openerp-reporting-engines/update-7.0-report_xls into lp:openerp-reporting-engines.