← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename into lp:ocb-web/6.1

 

Review: Needs Fixing

a lot of good point above, I agree with most.

Except for the first two: In my opinion, it is a serious problem that file names are not descriptive, and I doubt that you can do this without a hell of monkey patching in a module.

Concerning generating the actual file name, I'd propose to make it as predictable as possible: Use name_get, and always prefix it by the (possibly translated) report name.
-- 
https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/200007
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web/6.1.


References