openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe into lp:account-financial-report.

Requested reviews:
  Account Report Core Editors (account-report-core-editor)
Related bugs:
  Bug #1266701 in Account - Financial Report: "[7.0] account_journal_report_xls may prevent server to start"
  https://bugs.launchpad.net/account-financial-report/+bug/1266701

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe/+merge/200810

allow having this branch present even if report_xls is not available

since openerp imports all the possible addons at startup, we must take care of possible import errors generated by cross dependencies
-- 
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe/+merge/200810
Your team Account Report Core Editors is requested to review the proposed merge of lp:~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe into lp:account-financial-report.

=== modified file 'account_financial_report_webkit_xls/__init__.py'
--- account_financial_report_webkit_xls/__init__.py	2013-10-31 18:01:41 +0000
+++ account_financial_report_webkit_xls/__init__.py	2014-01-08 11:39:06 +0000
@@ -21,4 +21,9 @@
 ##############################################################################
 
 from . import wizard
-from . import report
+try:
+    from . import report
+except ImportError:
+    import logging
+    logging.getLogger('openerp.module').warning('report_xls not available in addons path. account_financial_report_webkit_xls will not be usable')
+

=== modified file 'account_move_line_report_xls/__init__.py'
--- account_move_line_report_xls/__init__.py	2013-10-31 17:42:46 +0000
+++ account_move_line_report_xls/__init__.py	2014-01-08 11:39:06 +0000
@@ -21,4 +21,9 @@
 ##############################################################################
 
 from . import account_move_line
-from . import report
+try:
+    from . import report
+except ImportError:
+    import logging
+    logging.getLogger('openerp.module').warning('report_xls not available in addons path. account_financial_report_webkit_xls will not be usable')
+