openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe into lp:account-financial-report

To: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Wed, 08 Jan 2014 11:43:58 -0000
In-reply-to: <20140108113926.24855.62382.launchpad@ackee.canonical.com>
Reply-to: mp+200810@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Hi, Alexandre,

Don't you think it's better to defer the loading of report_xls imports on report folder to the moment when reports are launched (that is to say, when the module is installed), instead of the try/catch block?

Regards.
-- 
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe/+merge/200810
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.

References

lp:~camptocamp/account-financial-report/7.0-dont_crash_if_report_xls_not_available-afe into lp:account-financial-report
From: Alexandre Fayolle - camptocamp, 2014-01-08