openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Public bug reported:

In revision 9599 (http://bazaar.launchpad.net/~ocb/ocb-
addons/7.0/revision/9599), Yannick made a change in the signature of the
method, adding a positional argument called 'target_move'.

I know that this method is internal, but we are using it in Spain to get
taxes values for vat reports easily. The problem is not the change
itself, but the difference with the official branch, so we cannot use
the same code for both branches. For now, I'm going to use a workaround
catching the exception or reading method definition, but please fix this
ASAP.

I think one possible solution is to put the argument as keyword argument
with default value None, but I have to test if it's correct, because I
don't know that code.

Another thing that it's important is to prevent this kind of changes
that provokes side effects, so maybe positional arguments must be
forbidden. What do you think? Do I talk this on the community list?

Regards.

** Affects: ocb-addons
     Importance: Undecided
     Assignee: Yannick Vaucher @ Camptocamp (yvaucher-c2c)
         Status: New

** Changed in: ocb-addons
     Assignee: (unassigned) => Yannick Vaucher @ Camptocamp (yvaucher-c2c)

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1269965

Title:
  [7.0] Method _get_lines signature changed

Status in OpenERP Community Backports (Addons):
  New

Bug description:
  In revision 9599 (http://bazaar.launchpad.net/~ocb/ocb-
  addons/7.0/revision/9599), Yannick made a change in the signature of
  the method, adding a positional argument called 'target_move'.

  I know that this method is internal, but we are using it in Spain to
  get taxes values for vat reports easily. The problem is not the change
  itself, but the difference with the official branch, so we cannot use
  the same code for both branches. For now, I'm going to use a
  workaround catching the exception or reading method definition, but
  please fix this ASAP.

  I think one possible solution is to put the argument as keyword
  argument with default value None, but I have to test if it's correct,
  because I don't know that code.

  Another thing that it's important is to prevent this kind of changes
  that provokes side effects, so maybe positional arguments must be
  forbidden. What do you think? Do I talk this on the community list?

  Regards.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1269965/+subscriptions