openerp-community-reviewer team mailing list archive

["Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review

Holger,

It looks good, with a few small remarks:

* I would expand further the description in __openerp__.py, stating explicitly that we are overriding the existing report from the account module. Furthermore: apart from the period, the query is the same as the account module? Maybe a link to the bug?

* read_group could benefit from a docstring to explain what is going on.

* flake8 shows some issues, like spaces before colons and eigth-space indentation.

Thanks for your work
-- 
https://code.launchpad.net/~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear/+merge/201968
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1.