openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~nemry/partner-contact-management/7.0-partner-firstname into lp:partner-contact-management

To: "Jonathan Nemry \(Acsone\)" <jonathan.nemry@xxxxxxxxx>
From: "Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>
Date: Thu, 23 Jan 2014 13:50:57 -0000
In-reply-to: <20140122171223.9166.82842.launchpad@ackee.canonical.com>
Reply-to: mp+202713@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

LGTM.

Just a little note, at line 229, I would avoid to use the name 'fields' as a variable since it's also the name of the module probably the most used in openerp.

And the cherry on the cake, a MP with automated tests!!
-- 
https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202713
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.

References

[Merge] lp:~nemry/partner-contact-management/7.0-partner-firstname into lp:partner-contact-management
From: Jonathan Nemry (Acsone), 2014-01-22