openerp-community-reviewer team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hello,

Thanks for the work.

You should check code with a lynter and correct PEP8 etc.
You may add your authorship in manifest and file header of partner.py

 # * if firstname change in the new name: lastname is set to new name, firstname is reset
You should add a comment on the motivation of this choice, for future record.

else it seems fine.

Regards

Nicolas


-- 
https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202713
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.