openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #03169
Re: lp:~camptocamp/stock-logistic-flows/7.0-add_stock_picking_priority-afe into lp:stock-logistic-flows
Review: Approve quick code review and testing
Technically,
The selection values ("[('0', 'Normal'),('1', 'Urgent'),('2', 'Very Urgent')]") could be usefully factored into a constant.
That would allow others to create modules to add other priorities.
Also, would a priority of "-1" be correctly placed after all positive priorities?
Functionally, it would be useful push this priority up to the sale orders too (but maybe that would belong to another module?)
Other than that it seems to work fine and it rocks.
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add_stock_picking_priority-afe/+merge/197206
Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows.
Follow ups
References