openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

On 01/24/2014 04:09 PM, Lionel Sausin - Numérigraphe wrote:
> Review: Approve quick code review and testing
>
> Technically,
> The selection values ("[('0', 'Normal'),('1', 'Urgent'),('2', 'Very Urgent')]") could be usefully factored into a constant.
> That would allow others to create modules to add other priorities.
> Also, would a priority of "-1" be correctly placed after all positive priorities?
>
> Functionally, it would be useful push this priority up to the sale orders too (but maybe that would belong to another module?)
>
> Other than that it seems to work fine and it rocks.
>

This MP has been merged already.  The changes you propose could be done 
in a new proposal.  I agree for the sales, in a new module to not add a 
dependency on 'sale' on this module.

-- 
Guewen Baconnier
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 39
Office: +41 21 619 10 10
http://www.camptocamp.com/

https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add_stock_picking_priority-afe/+merge/197206
Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows.