openerp-community-reviewer team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing no test, code review

Hello,

Some neat picks:
PEP8 in __openerp__.py
Some trailing white space here and there.

Here I'm not sure of this expression:

                domain = (
                    ['&', ('id', '=', res_id)] +
                    literal_eval(attachment.domain)

Why do you use ast.literal_eval instead of openerp safe_eval ?


-- 
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-add_email_template_conditional_attachment/+merge/202740
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.