openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~therp-nl/server-env-tools/7.0-add_email_template_conditional_attachment into lp:server-env-tools

To: mp+202740@xxxxxxxxxxxxxxxxxx
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Mon, 27 Jan 2014 10:05:14 -0000
In-reply-to: <20140122203923.24531.29297.launchpad@ackee.canonical.com>
Reply-to: mp+202740@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Hi Nicolas, thanks for the review! I fixed up __openerp__.py.

Using ast.literal_eval here because its functionality is a subset of safe_eval and it is standard python functionality. So it should be safer than safe_eval in this case. Can you live with that?

-- 
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-add_email_template_conditional_attachment/+merge/202740
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.

References

lp:~therp-nl/server-env-tools/7.0-add_email_template_conditional_attachment into lp:server-env-tools
From: Stefan Rijnhart (Therp), 2014-01-22