openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

To: mp+204957@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Wed, 05 Feb 2014 14:58:06 -0000
In-reply-to: <20140205145426.551.31045.launchpad@ackee.canonical.com>
Reply-to: mp+204957@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Are you sure the code for excluding products is correct? I don't see full code in the MP, but I think that you are only including products with the check instead of excluding them.

Regards.
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management.

References

[Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management
From: Matthieu Dietrich @ camptocamp, 2014-02-05