openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

To: mp+204957@xxxxxxxxxxxxxxxxxx
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Fri, 21 Mar 2014 15:56:40 -0000
In-reply-to: <20140205145426.551.31045.launchpad@ackee.canonical.com>
Reply-to: mp+204957@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Seems ok to me. I wonder if we shouldn't add a migration script to set is_in_hours_block to True on all products so the behavior does not change after the update of the module, avoiding to perturb users. What do you think? 
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management.

References

[Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management
From: Matthieu Dietrich @ camptocamp, 2014-02-05